Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of stefan.fuhrmann@wandisco.com
 designates 209.85.213.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20140505120603.GA233@jim.stsp.name>
References: <20140502140741.9BC1A23888D7@eris.apache.org>
	<20140505120603.GA233@jim.stsp.name>
Date: Tue, 6 May 2014 00:18:27 +0200
Message-ID: 
 <CA+t0gk3Nwxw2SahGVrprS7oY+JXYBo4KKNsQtWuWkpuDDX24ag@mail.gmail.com>
Subject: Re: svn commit: r1591919 - in /subversion/trunk/subversion: include/
 include/private/ libsvn_fs/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_fs_x/
 libsvn_ra_svn/ libsvn_subr/ svnserve/ tests/ tests/libsvn_fs_fs/
From: Stefan Fuhrmann <stefan.fuhrmann@wandisco.com>
To: Subversion Development <dev@subversion.apache.org>
Content-Type: multipart/alternative; boundary=089e0141a8d8b90bb204f8ae8200

--089e0141a8d8b90bb204f8ae8200
Content-Type: text/plain; charset=UTF-8

On Mon, May 5, 2014 at 2:06 PM, Stefan Sperling <stsp@elego.de> wrote:

> On Fri, May 02, 2014 at 02:07:40PM -0000, stefan2@apache.org wrote:
> > Author: stefan2
> > Date: Fri May  2 14:07:40 2014
> > New Revision: 1591919
> >
> > URL: http://svn.apache.org/r1591919
> > Log:
> > APR mutexes don't support recursive locking on all platforms.
> > As a result, trying to take out the same lock twice in the
> > same thread will cause a lock up under e.g. Linux.  This patch
> > adds an option to svn_mutex__t that detects recursive locking
> > attempts in most cases and returns a proper error.
>
> > * subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c
> >   (never_reached,
> >    lock_again): Callback functions required by the new test.
> >   (recursive_locking): New test expecting an SVN_ERR_RECURSIVE_LOCK.
> >   (test_funcs): Register the new test.
>
> Hi Stefan,
>
> This new test fails on the bb-openbsd bot.
>
> http://ci.apache.org/builders/bb-openbsd/builds/12/steps/Test/logs/faillog-ra_local-fsfs
>
> Can you please look into this?
>
> Note that the bot is deliberately compiling APR and everything else
> without support for threads. Perhaps the test or other code doesn't
> take this possibility into account?
>

Since double locking attempts on the same file
may be problem even without threading support,
we should detect recursive mutex locks there
as well. r1592640 may do the trick. Could not
test it, though.

--Stefan^2.

--089e0141a8d8b90bb204f8ae8200
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On M=
on, May 5, 2014 at 2:06 PM, Stefan Sperling <span dir=3D"ltr">&lt;<a href=
=3D"mailto:stsp@elego.de" target=3D"_blank">stsp@elego.de</a>&gt;</span> wr=
ote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex">
On Fri, May 02, 2014 at 02:07:40PM -0000, <a href=3D"mailto:stefan2@apache.=
org">stefan2@apache.org</a> wrote:<br>
&gt; Author: stefan2<br>
&gt; Date: Fri May =C2=A02 14:07:40 2014<br>
&gt; New Revision: 1591919<br>
&gt;<br>
&gt; URL: <a href=3D"http://svn.apache.org/r1591919" target=3D"_blank">http=
://svn.apache.org/r1591919</a><br>
&gt; Log:<br>
&gt; APR mutexes don&#39;t support recursive locking on all platforms.<br>
&gt; As a result, trying to take out the same lock twice in the<br>
&gt; same thread will cause a lock up under e.g. Linux. =C2=A0This patch<br=
>
&gt; adds an option to svn_mutex__t that detects recursive locking<br>
&gt; attempts in most cases and returns a proper error.<br>
<br>
&gt; * subversion/tests/libsvn_fs_fs/fs-fs-pack-test.c<br>
&gt; =C2=A0 (never_reached,<br>
&gt; =C2=A0 =C2=A0lock_again): Callback functions required by the new test.=
<br>
&gt; =C2=A0 (recursive_locking): New test expecting an SVN_ERR_RECURSIVE_LO=
CK.<br>
&gt; =C2=A0 (test_funcs): Register the new test.<br>
<br>
Hi Stefan,<br>
<br>
This new test fails on the bb-openbsd bot.<br>
<a href=3D"http://ci.apache.org/builders/bb-openbsd/builds/12/steps/Test/lo=
gs/faillog-ra_local-fsfs" target=3D"_blank">http://ci.apache.org/builders/b=
b-openbsd/builds/12/steps/Test/logs/faillog-ra_local-fsfs</a><br>
<br>
Can you please look into this?<br>
<br>
Note that the bot is deliberately compiling APR and everything else<br>
without support for threads. Perhaps the test or other code doesn&#39;t<br>
take this possibility into account?<br></blockquote><br></div><div class=3D=
"gmail_quote">Since double locking attempts on the same file<br></div><div =
class=3D"gmail_quote">may be problem even without threading support,<br>we =
should detect recursive mutex locks there<br>
as well. r1592640 may do the trick. Could not<br></div><div class=3D"gmail_=
quote">test it, though.<br><br></div><div class=3D"gmail_quote">--Stefan^2.=
<br></div></div></div>

--089e0141a8d8b90bb204f8ae8200--