Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of ben@reser.org designates
 50.197.89.41 as permitted sender)
Message-ID: <537B7B84.3040207@reser.org>
Date: Tue, 20 May 2014 08:57:56 -0700
From: Ben Reser <ben@reser.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:30.0) Gecko/20100101 Thunderbird/30.0
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Mattias_Engdeg=E5rd?= <mattiase@bredband.net>,
 "dev@subversion.apache.org Development" <dev@subversion.apache.org>
Subject: Re: [PATCH] generate subversion.pot in dist.sh
References: <371D2C04-45CA-4CD4-BA01-81708F04E9A3@bredband.net>
In-Reply-To: <371D2C04-45CA-4CD4-BA01-81708F04E9A3@bredband.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

On 5/6/14, 2:52 PM, Mattias Engdeg�rd wrote:
> Translators will need the subversion.pot file; it should be present in the
> source distribution. Presumably, the right way to ensure that is to have
> dist.sh generate it, similar to the way the configure script is created.
> 
> [[[
> Have dist.sh generate subversion.pot for the benefit of translators who need
> it in the source distribution.
> 
> * tools/dist/dist.sh: Generate subversion.pot by running po-update.sh.
> ]]]

Why should the pot file be present in the distribution package?  Shouldn't
translators be working against a SVN checkout and not a distribution package?

Looking at the output on 1.8.x it adds 348 KB of uncompressed size to our
source.  That's obviously not a huge problem, but I just don't understand what
value this really creates.  For most of users this is useless (they aren't
translators).  For those that need it, it's trivially created.

Configure, which you're using as an example is used by everyone that builds on
anything other than Windows.

I see no problem with the patch itself, but I don't understand the purpose.