subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: Three-way merge markers by default
Date Thu, 01 May 2014 22:58:24 GMT
Daniel Shahaf wrote on Thu, May 01, 2014 at 22:52:06 +0000:
> Philip Martin wrote on Thu, May 01, 2014 at 19:04:04 +0100:
> > Philip Martin <philip.martin@wandisco.com> writes:
> > 
> > > svn_diff_conflict_display_modified_latest is similar to the output of
> > > GNU diff3 which is probably why it was chosen.  Changing it might cause
> > > problems for tools that parse the output, but one option for anyone
> > > affected would be to use GNU diff3 with --diff3-cmd.
> > 
> > We have our own standalone diff3 in tools/diff/diff3.  It currently
> > hard-codes the same 2-way output that is hard-coded in libsvn_wc but we
> > could make it a command line option.  Users who want precise control
> > over the ouput could configure it as an external diff3 command, although
> > we might want to rename it svndiff3.
> > 
> 
> "svndiff3" specifically might not be a good name because of the
> potential for confusion with svndiff0 and svndiff1 (the libsvn_delta
> binary delta formats).  "svn-diff3" looks like a subcommand "diff3" of
> "svn" (following a pattern used by git, hg, pkgng, etc).  Perhaps
> 'svn_diff3'?

'make install-tools' puts tools/diff/diff3 in $(prefix)/bin/svn-tools/diff3,
along with all other tools.  Why would we need to rename it, then?

Actually, at least on unix, we could implicitly provide "prefix" as a
replaceable in the config file, so that people could write:

    % cat ~/.subversion/config
    [helpers]
    diff3-cmd = %(prefix)s/svn-tools/diff3

and it would work regardless of where the 'svn' binary happened to be
installed.  (For example, this could be useful if the homedir is shared
between multiple boxes that don't all have svn installed into the same
prefix.)

Daniel

Mime
View raw message