Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 700EE10091 for ; Sat, 11 Jan 2014 07:22:23 +0000 (UTC) Received: (qmail 7390 invoked by uid 500); 11 Jan 2014 07:22:16 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 6999 invoked by uid 500); 11 Jan 2014 07:22:05 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 6988 invoked by uid 99); 11 Jan 2014 07:22:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 07:22:02 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ben@reser.org designates 50.197.89.41 as permitted sender) Received: from [50.197.89.41] (HELO mail.brain.org) (50.197.89.41) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 07:21:56 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.brain.org (Postfix) with ESMTP id F1AB4179E11D; Fri, 10 Jan 2014 23:21:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at fornix.brain.org Received: from mail.brain.org ([127.0.0.1]) by localhost (fornix.brain.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6TT3lOp5RIjx; Fri, 10 Jan 2014 23:21:35 -0800 (PST) Received: from fmri.brain.org (fmri.brain.org [IPv6:2001:470:e966:5:223:dfff:fedf:433d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.brain.org (Postfix) with ESMTPSA id 9AEF0179E0C1; Fri, 10 Jan 2014 23:21:35 -0800 (PST) Message-ID: <52D0F13B.1090208@reser.org> Date: Fri, 10 Jan 2014 23:22:35 -0800 From: Ben Reser User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:27.0) Gecko/20100101 Thunderbird/27.0 MIME-Version: 1.0 To: Philip Martin , Bert Huijben CC: 'Lieven Govaerts' , 'Subversion Development' Subject: Re: Segfault in mod_dav_svn with repositories on / References: <015801cf0df9$767d1380$63773a80$@qqmail.nl> <8761psqbb1.fsf@ntlworld.com> In-Reply-To: <8761psqbb1.fsf@ntlworld.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 1/10/14, 4:19 AM, Philip Martin wrote: > It is not fixed. If you look a few lines down we pass a NULL path: > > apr_text_append(resource->pool, option, > dav_svn__build_uri(resource->info->repos, > DAV_SVN__BUILD_URI_ACT_COLLECTION, > SVN_INVALID_REVNUM, NULL, > 1 /* add_href */, > resource->pool)); > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7f318b7fe700 (LWP 21796)] > 0x00007f319a42a391 in dav_svn__build_uri (repos=0x7f3196f682b0, > what=DAV_SVN__BUILD_URI_ACT_COLLECTION, revision=-1, path=0x0, add_href=1, > pool=0x7f3196f6c028) at ../src/subversion/mod_dav_svn/util.c:244 > 244 if (root_path[0] == '/' && root_path[1] == '\0') > (gdb) p root_path > $1 = 0x0 > (gdb) up > #1 0x00007f319a42bc2f in get_option (resource=0x7f3196f68330, > elem=0x7f3196f68728, option=0x7f318b7fdb00) > at ../src/subversion/mod_dav_svn/version.c:188 > 188 apr_text_append(resource->pool, option, I reverted Bert's fix and applied a better one in r1557320.