subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <>
Subject Re: svn cleanup and unreferenced pristines
Date Fri, 10 Jan 2014 23:17:11 GMT
On 10.01.2014 20:11, C. Michael Pilato wrote:
> On 01/10/2014 02:00 PM, Ben Reser wrote:
>> Wish that cleaning up pristines hadn't been overloaded into cleanup.  Ran into
>> a situation where I crashed the client today.  So I needed to run cleanup, but
>> I hadn't run cleanup in a very long time so of course it took a while since it
>> also went through all the pristines to cleanup the unreferenced ones.  We don't
>> even have an option to say not to do that.
>> I'm not sure what we should do here.  But just always cleaning up pristines on
>> cleanup with no args seems like a bad choice from a UI perspective.  If we
>> start cleaning up pristines automatically based on some sort of expiration
>> (balancing speed for switches and updates between revisions and space) then I
>> can't imagine we'll want cleanup destroying the cached data.
>> Do we want a separate sub-command for managing pristines?  Or do we want to
>> just add an option to cleanup to say to remove unreferenced pristines?
> Just a reminder that there can be performance benefits to not being too
> aggressive in our pristine purging, since update-style operations will
> consult the pristine cache before slurping file contents from the
> server.  I think that's what you're alluding to when you say "balancing
> speed for switches and updates", but just wanted to call that out
> explicitly.
> -0.9 on a new subcommand.  Hanging an option on 'svn cleanup' seems
> quite reasonable, though.

We could even not add an option, and instead only remove pristines that
are "old enough"; e.g., touch the file timestamp every time a pristine
file is used, and have "svn cleanup" only remove those prisitines that
haven't been used for a certain period of time.

If we can come up with good enough heuristics, I'd prefer that to yet
another command-line option that has to be documented, maintained, and
explained a zillion time on the users@ list.

-- Brane

Branko ─îibej | Director of Subversion
WANdisco // Non-Stop Data

View raw message