Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: error (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=btopenworld.com;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=XO8T6zVHJtZdYj9OZplMTtA5LZDT+IAAiKpHltvc8bfbFpWKzS6qeEfRvRsCMxXbvsAYjzgv5clfabiOUhsbc7kK51DEdGR6QNbjHPRx+VxUsFoFqJqhIwFh7svvRFgaYkJ7yfhWJi1r4k5pJxgm/RbFsPYT8ITnYVacxm4d4rY=;
References: <20130612102935.5F08123888E4@eris.apache.org>
 <20130612105857.GB12209@tarsus.local2>
Message-ID: <1371036151.49095.YahooMailNeo@web186105.mail.ir2.yahoo.com>
Date: Wed, 12 Jun 2013 12:22:31 +0100 (BST)
From: Julian Foad <julianfoad@btopenworld.com>
Reply-To: Julian Foad <julianfoad@btopenworld.com>
Subject: Re: svn commit: r1492134 -
 /subversion/trunk/subversion/tests/cmdline/blame_tests.py
To: "dev@subversion.apache.org" <dev@subversion.apache.org>
Cc: "commits@subversion.apache.org" <commits@subversion.apache.org>
In-Reply-To: <20130612105857.GB12209@tarsus.local2>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Daniel Shahaf wrote:=0A=0A> danielsh@apache.org wrote on Wed, Jun 12, 2013 =
at 10:29:35 -0000:=0A>>  Author: danielsh=0A>>  Date: Wed Jun 12 10:29:34 2=
013=0A>>  New Revision: 1492134=0A>> =0A>>  URL: http://svn.apache.org/r149=
2134=0A>>  Log:=0A>>  Add an XFail test for 'svn blame -r 3:1' (where 3 > 1=
).=0A>> =0A>>  Not filing an issue since I plan to commit a fix soon.=0A=0A=
What behaviour change are you planning for 'blame'?=0A=0AI ask because I do=
n't think it's obvious.=0A=0AFor example, it would be useful to have a mode=
 that looks forward in time from a given revision, to find the *next* revis=
ion at which each line is changed after the starting revision.=A0 Is that t=
he behaviour you are planning?=0A=0A- Julian=0A=0A=0A> Update: Bert found a=
 potential problem with peg revisions here that=0A> might require revving a=
n RA API, so it'll take me longer to get to=0A> committing a fix than I pla=
nned.=0A> =0A> Current WIP patch:=0A> =0A> Index: subversion/libsvn_client/=
blame.c=0A> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A> --- sub=
version/libsvn_client/blame.c=A0=A0=A0 (revision 1492120)=0A> +++ subversio=
n/libsvn_client/blame.c=A0=A0=A0 (working copy)=0A> @@ -466,7 +466,7 @@ fil=
e_rev_handler(void *baton, const char *path, sv=0A> =A0  /* Create the rev =
structure. */=0A> =A0  frb->rev =3D apr_pcalloc(frb->mainpool, sizeof(struc=
t rev));=0A> =0A> -=A0 if (revnum < frb->start_rev)=0A> +=A0 if (revnum < M=
IN(frb->start_rev, frb->end_rev))=0A> =A0 =A0  {=0A> =A0 =A0 =A0  /* We sho=
uldn't get more than one revision before the starting=0A> =A0 =A0 =A0 =A0 =
=A0 revision (unless of including merged revisions). */=0A> @@ -479,7 +479,=
8 @@ file_rev_handler(void *baton, const char *path, sv=0A> =A0 =A0  }=0A> =
=A0  else=0A> =A0 =A0  {=0A> -=A0 =A0 =A0 SVN_ERR_ASSERT(revnum <=3D frb->e=
nd_rev);=0A> +=A0 =A0 =A0 /* 1+ for the "youngest to oldest" blame */=0A> +=
=A0 =A0 =A0 SVN_ERR_ASSERT(revnum <=3D 1 + MAX(frb->end_rev, frb->start_rev=
));=0A> =0A> =A0 =A0 =A0  /* Set values from revision props. */=0A> =A0 =A0=
 =A0  frb->rev->revision =3D revnum;=0A> @@ -578,6 +579,7 @@ svn_client_bla=
me5(const char *target,=0A> =A0  svn_stream_t *last_stream;=0A> =A0  svn_st=
ream_t *stream;=0A> =A0  const char *target_abspath_or_url;=0A> +=A0 svn_re=
vnum_t youngest;=0A> =0A> =A0  if (start->kind =3D=3D svn_opt_revision_unsp=
ecified=0A> =A0 =A0 =A0  || end->kind =3D=3D svn_opt_revision_unspecified)=
=0A> @@ -599,11 +601,6 @@ svn_client_blame5(const char *target,=0A> =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0  target_abspath_or_url, ra_session,=0A> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0  start, pool));=0A> =
=0A> -=A0 if (end_revnum < start_revnum)=0A> -=A0 =A0 return svn_error_crea=
te=0A> -=A0 =A0 =A0 (SVN_ERR_CLIENT_BAD_REVISION, NULL,=0A> -=A0 =A0 =A0  _=
("Start revision must precede end revision"));=0A> -=0A> =A0  /* We check t=
he mime-type of the yougest revision before getting all=0A> =A0 =A0 =A0 the=
 older revisions. */=0A> =A0  if (!ignore_mime_type)=0A> @@ -674,8 +671,14 =
@@ svn_client_blame5(const char *target,=0A> =A0 =A0 =A0 We need to ensure =
that we get one revision before the start_rev,=0A> =A0 =A0 =A0 if available=
 so that we can know what was actually changed in the start=0A> =A0 =A0 =A0=
 revision. */=0A> +=A0 SVN_ERR(svn_ra_get_latest_revnum(ra_session, &younge=
st, frb.currpool));=0A> =A0  SVN_ERR(svn_ra_get_file_revs2(ra_session, "",=
=0A> -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 start=
_revnum - (start_revnum > 0 ? 1 : 0),=0A> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 start_revnum =0A> +=A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 - (0 < start_revnum && start_revnum=
 =0A> < end_revnum ? 1 : 0)=0A> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 + (youngest > start_revnum && =0A> start_revnum > e=
nd_revnum ? 1 : 0),=0A> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 /* ### pass MAX(start_revnum, end_revnum) as =0A> peg thru =
to svn_fs_revision_root() */=0A> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 /* ### blame 5 fails. */=0A> +=A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* ### check svn_repos_get_file=
_revs2 tests. */=0A> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0  end_revnum, include_merged_revisions,=0A> =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0  file_rev_handler, &frb, pool))=
;=0A> =0A> =0A>>  * subversion/tests/cmdline/blame_tests.py=0A>> =A0  (blam=
e_youngest_to_oldest): New test, XFail.=0A>> =A0  (test_list): Run it.=0A>