subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: serf error handling for locks without authn
Date Tue, 04 Jun 2013 00:01:50 GMT
On Mon, Jun 3, 2013 at 7:47 PM, Philip Martin
<philip.martin@wandisco.com> wrote:
>...
> However there is another HTTP_UNAUTHORIZED: mod_dav_svn returns it from
> lock.c:refresh_locks:
>
>   /* Sanity check: does the incoming token actually represent the
>      current lock on the incoming resource? */
>   if ((! slock)
>       || (strcmp(token->uuid_str, slock->token) != 0))
>     return dav_svn__new_error(resource->pool, HTTP_UNAUTHORIZED,
>                               DAV_ERR_LOCK_SAVE_LOCK,
>                               "Lock refresh request doesn't match existing "
>                               "lock.");
>
> I think this is a client sending the wrong lock token in an If: header,
> so perhaps "412 Precondition Failed" is correct here?

Yeah. That would work great.

Cheers,
-g

Mime
View raw message