subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <danie...@elego.de>
Subject Re: errno intersects APR error codes
Date Sun, 02 Jun 2013 22:35:43 GMT
Johan Corveleyn wrote on Sun, Jun 02, 2013 at 22:01:07 +0200:
> If I add a 'self' parameter to the signature of errno_filter in
> gen_win.py, it seems to work (i.e. no error / warning output anymore).
> But I'm not sure if that's the right fix ... my Python knowledge is
> not very advanced :-).
> 

Yes, it is.  errno_filter() is an instance method and as such needs
a 'self' first parameter (like the other errno_filter method in the
patch already has).  The definition is in gen_win.py is used by
gen_msvc_dsp.py and gen_vcnet_vcproj.py, one of which is used by
gen-make.py.

r1488803.

> (thanks for the patch BTW)
> 
> --
> Johan

Mime
View raw message