Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of ben@reser.org designates
 50.197.89.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAC9r9zaAetw8n_FjikKHgxJsoTmEVzi4LDeXB2E=ycwnOcuuaQ@mail.gmail.com>
References: <092299f6-ef92-4fcb-b591-8d938337b47c@googlegroups.com>
	<CADkdwvS_t=4_fVHMZddfoA2+9AdmiMfO5Jx+-cpPOLvGppEBaQ@mail.gmail.com>
	<65ecbf72-223a-4296-9b80-5e5484f5baff@googlegroups.com>
	<CADkdwvRUgZNKnq-UbCkvz6OhUSNwCpkX0UDMr70E1zaW+NPNUg@mail.gmail.com>
	<CAC9r9zaAetw8n_FjikKHgxJsoTmEVzi4LDeXB2E=ycwnOcuuaQ@mail.gmail.com>
Date: Wed, 13 Feb 2013 08:28:55 -0800
Message-ID: 
 <CADkdwvRifK7yu7B0x_==i_hVw6zb28X9y=YQOErsC3zZ2V1Hgw@mail.gmail.com>
Subject: Re: [PATCH] Small fixes to the Perl bindings
From: Ben Reser <ben@reser.org>
To: Roderich Schupp <roderich.schupp@gmail.com>
Cc: Subversion Development <dev@subversion.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Feb 13, 2013 at 6:57 AM, Roderich Schupp
<roderich.schupp@gmail.com> wrote:
> Ouch. Your diagnosis is correct, though I can't reproduce your symptoms :)
> The previously failing tests in t/9wc.t do not cover the problematic
> conversion.
> For that, you would have to pass a Perl _svn_opt_opt_revision_t object
> (e.g. obtained from the return value of
> SVN::Wc::parse_externals_description3)
> into a wrapped function expecting a C *svn_opt_revision_t, e.g.
> SVN::Client::log.

Actually you don't even have to do that.  Retrieving values out of a
svn_opt_revision_t object would have exercised the issue since you're
calling the generated accessor function (e.g.
_wrap_svn_opt_revision_t_kind_get()) which is taking the
svn_opt_revision_t object which SWIG applies the typemap to.

> Anyway, the pointer to pointer thing is ugly. What about the following patch
> that makes it more explicit that the converted argument may be assigned to?

Thanks that is cleaner.  Applied in r1445705.