subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/
Date Sun, 03 Feb 2013 12:42:42 GMT
On Sun, Feb 3, 2013 at 6:42 AM, Stefan Sperling <stsp@elego.de> wrote:

> On Sun, Feb 03, 2013 at 06:16:03AM -0500, Justin Erenkrantz wrote:
> > On Sun, Feb 3, 2013 at 6:06 AM, Justin Erenkrantz <justin@erenkrantz.com
> >wrote:
> >
> > > I thought we treated application/xml as text at one time?  -- justin
> > >
> >
> > Yes, we did...and Ben -1'ed it back in 2004.  See:
> >
> >
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=374218
> >
> > I guess...but...really?  Is the only way for a user to override this is
> to
> > manually set their local auto-props?  *sigh*  -- justin
>
> Perhaps we should treat mime-types that contain 'charset=UTF-8'
> as text by default? libmagic is able to detect the charset AFAIK.
> Our code currently removes charset information from the mime-type
> returned by libmagic.
>
> I don't really like the idea of adding yet another special case
> to our definition of what a "text" mime-type is. But it might
> be worth doing this if it impacts a lot of people.
>

% file -i -k index.shtml
index.shtml: application/xml; charset=us-ascii

Not all of us use UTF-8, but yes the sentiment is valid.  =)  I do wonder
if printing out this new message saying SVN considers XML files as binary
is going to increase the amount of people realizing that they are tripping
over this.  -- justin

Mime
View raw message