subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Reser <...@reser.org>
Subject Re: [PATCH] Small fixes to the Perl bindings
Date Fri, 15 Feb 2013 20:36:34 GMT
On Fri, Feb 15, 2013 at 11:41 AM, Ben Reser <ben@reser.org> wrote:
> I wouldn't bother to do the testing like this.  You can create an
> _p_svn_opt_revision_t without needing to get it from something like
> svn_wc_parse_externals_description3().  e.g.
>
> my $rev = SVN::_Core::new_svn_opt_revision_t();
> $rev->kind($SVN::Core::opt_revision_number);
> $rev->value->number(1445267);
>
> In which case we can put the test code in the 3client.t tests, which
> already has a repo.

Done in r1446761.

> This is probably a good change to have more complete coverage of
> testing that externals code.  I'll make this change irrespective of
> the other changes.

Done in r1446753.

Mime
View raw message