subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Reser <>
Subject Re: [PATCH] Small fixes to the Perl bindings
Date Wed, 13 Feb 2013 16:28:55 GMT
On Wed, Feb 13, 2013 at 6:57 AM, Roderich Schupp
<> wrote:
> Ouch. Your diagnosis is correct, though I can't reproduce your symptoms :)
> The previously failing tests in t/9wc.t do not cover the problematic
> conversion.
> For that, you would have to pass a Perl _svn_opt_opt_revision_t object
> (e.g. obtained from the return value of
> SVN::Wc::parse_externals_description3)
> into a wrapped function expecting a C *svn_opt_revision_t, e.g.
> SVN::Client::log.

Actually you don't even have to do that.  Retrieving values out of a
svn_opt_revision_t object would have exercised the issue since you're
calling the generated accessor function (e.g.
_wrap_svn_opt_revision_t_kind_get()) which is taking the
svn_opt_revision_t object which SWIG applies the typemap to.

> Anyway, the pointer to pointer thing is ugly. What about the following patch
> that makes it more explicit that the converted argument may be assigned to?

Thanks that is cleaner.  Applied in r1445705.

View raw message