subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fuhrmann <stefan.fuhrm...@wandisco.com>
Subject Re: svn commit: r1442071 - in /subversion/trunk/subversion/libsvn_fs_fs: dag.c temp_serializer.c
Date Thu, 21 Feb 2013 11:20:06 GMT
On Mon, Feb 4, 2013 at 2:02 PM, Philip Martin <philip.martin@wandisco.com>wrote:

> stefan2@apache.org writes:
>
> > Author: stefan2
> > Date: Mon Feb  4 10:38:45 2013
> > New Revision: 1442071
> >
> > URL: http://svn.apache.org/viewvc?rev=1442071&view=rev
> > Log:
> > Speed up serialization of DAG and noderev structures for our caches.
> > Turns out that 503 bytes is often not sufficient for noderevs with
> > longer path names and even less so for DAG nodes.  Up that to 1007
> > bytes (+1 0-terminator +16 bytes memory management overhead = 1kB).
>
> These comments about the size would be better in the code.  Perhaps this
> number should be a named constant?
>

Done in r1448587.

Thanks for the review!

-- Stefan^2,

-- 
Certified & Supported Apache Subversion Downloads:
*

http://www.wandisco.com/subversion/download
*

Mime
View raw message