Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of brane@wandisco.com designates
 209.85.214.43 as permitted sender)
Message-ID: <50465168.3040008@wandisco.com>
Date: Tue, 04 Sep 2012 21:07:20 +0200
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:15.0) Gecko/20120824 Thunderbird/15.0
MIME-Version: 1.0
To: dev@subversion.apache.org
Subject: Re: thread safe
References: <5044FB5F.1080309@gmail.com> <50450EE1.50002@wandisco.com>
 <50451025.1050202@gmail.com> <50451130.5060508@wandisco.com>
 <50463B50.3030002@gmail.com> <50464913.8010906@wandisco.com>
 <50464B99.6000703@gmail.com>
In-Reply-To: <50464B99.6000703@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 04.09.2012 20:42, Stefan Küng wrote:
> Seems I got confused here:
> What we have to pass to almost each svn API is the config hash for the
> svn_client_ctx_t struct. That's what I need a copy of.

The svn_config_* functions work with svn_config_t object. The tmp_key
and tmp_value fields in those object are in fact the ones that prevent
you from reading the same svn_config_t from multiple threads without
synchronization.

> And as Bert already noticed: apr_hash_copy only does a shallow copy,
> not a deep copy. Seems I have to iterate over the hash and copy every
> item separately.

That is correct. You'll also have to duplicate the svn_config_t
structure itself, I think that essentially means doing an
svn_config_create and copying over "x_values" and
"section_names_case_sensitive"; and, of course, doing the deep copy of
"sections".

If you do the deep copy properly -- i.e., copying the keys and values
into the new config_t's pool as well as the hashes -- then you'll save
yourself a bit of trouble with pool lifetimes, too.

> I'll do that first in TSVN, then do some tests.
> After that I can use that code to create an svn_config_dup() API if
> still required.

Why not just write svn_config_dup in libsvn_subr/config.c? Surely
there's no reason to keep this functionality out of the core libraries.

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download