Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: local policy)
Date: Mon, 3 Sep 2012 19:51:15 +0100
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Raphael Kubo da Costa <rakuco@FreeBSD.org>
Cc: dev@subversion.apache.org
Subject: Re: [PATCH] Remove NLS check from kwallet.m4 (was Re: Does KWallet
 support really need NLS on?)
Message-ID: <20120903185115.GA28807@tarsus.local2>
References: <87harilxp6.fsf@FreeBSD.org>
 <20120901204154.GA23930@tarsus.local2>
 <87d324zqr0.fsf_-_@FreeBSD.org>
 <201209022211.14603.Arfrever.FTA@gmail.com>
 <20120902205225.GA14953@tarsus.local2>
 <87y5kr4atc.fsf@FreeBSD.org>
 <20120903184445.GA28487@tarsus.local2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120903184445.GA28487@tarsus.local2>
User-Agent: Mutt/1.5.21 (2010-09-15)

Daniel Shahaf wrote on Mon, Sep 03, 2012 at 19:44:45 +0100:
> Raphael Kubo da Costa wrote on Mon, Sep 03, 2012 at 08:15:11 -0300:
> > Daniel Shahaf <d.s@daniel.shahaf.name> writes:
> > 
> > > Arfrever Frehtes Taifersar Arahesis wrote on Sun, Sep 02, 2012 at 22:11:11 +0200:
> > >> We need to decide if we support GCC <4.3.0 on GNU systems.
> > >
> > > Can't kwallet.m4 only require --enable-nls if the compiler is gcc <4.3 ?
> > 
> > Or if building some version of Arfrever's test code fails? Speaking of
> > that, isn't the problem of disabling NLS, including
> > svn_private_config.h and risking including something else which may use
> > libintl.h independent of the kwallet code?
> 
> I think the correct fix is to include headers in the correct order ---
> in this case, to move the kwallet includes (which are "external library",
> ie, neither svn's code nor OS/libc) up within kwallet.cpp.

... and, rereading your mail, to ensure that we do that elsewhere in
Subversion, too.