subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1336128 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/
Date Thu, 10 May 2012 03:57:29 GMT
On Wed, May 9, 2012 at 10:07 AM, Stefan Sperling <stsp@elego.de> wrote:
> On Wed, May 09, 2012 at 09:59:39AM -0400, Mark Phippard wrote:
>> On Wed, May 9, 2012 at 8:18 AM,  <stsp@apache.org> wrote:
>> > Author: stsp
>> > Date: Wed May  9 12:18:37 2012
>> > New Revision: 1336128
>
>> > @@ -561,7 +563,7 @@ public interface ISVNClient
>> >               OutputStream outStream,
>> >               Depth depth, Collection<String> changelists,
>> >               boolean ignoreAncestry, boolean noDiffDeleted, boolean
force,
>> > -              boolean copiesAsAdds, boolean ignoreProps)
>> > +              boolean copiesAsAdds, boolean ignoreProps, boolean propsOnly)
>> >             throws ClientException;
>>
>> I do not know if these methods are new in 1.8, but if not, then this
>> is the public API.  So for compatibility you have to add a new method
>> with the  new additional options.  You do not need to add a "2" or
>> anything to the method name since Java does not require that, just add
>> another method to the interface.
>
> The parameter is new in 1.8. The ignoreProps parameter is new in 1.8, too,
> and I modeled my changes on those that added the ignoreProps parameter.
>
> So I suppose this change is alright?

Nope. People coding to the 1.7 API will not be providing that
parameter. Thus, it will not compile.

You need to define new methods that include the parameter, to
supplement the existing methods that do not have it. (yay,
polymorphism!)

Cheers,
-g

Mime
View raw message