Return-Path: X-Original-To: apmail-subversion-dev-archive@minotaur.apache.org Delivered-To: apmail-subversion-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 324D79CAE for ; Thu, 5 Apr 2012 20:49:14 +0000 (UTC) Received: (qmail 56501 invoked by uid 500); 5 Apr 2012 20:49:13 -0000 Delivered-To: apmail-subversion-dev-archive@subversion.apache.org Received: (qmail 56470 invoked by uid 500); 5 Apr 2012 20:49:13 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 56463 invoked by uid 99); 5 Apr 2012 20:49:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 20:49:13 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of hyrum.wright@wandisco.com designates 209.85.212.169 as permitted sender) Received: from [209.85.212.169] (HELO mail-wi0-f169.google.com) (209.85.212.169) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2012 20:49:07 +0000 Received: by wibhm17 with SMTP id hm17so121473wib.4 for ; Thu, 05 Apr 2012 13:48:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-gm-message-state; bh=mTYtEdyoYsNKz1AmpQE2vc0IFpIFiFmdxSoo9Bh63GM=; b=gbO4ZFrtgRJVQpnPEdU9MMauqoZfrIy+vX1Qr6gc32OQBJXAe96aVDb+1808RaE7SB wuCe9ziSk88ph+sA43ZZ0gWzXBn+MrAkJlDvjrwXJYQu1eevH3DkfGcYpDHrDo3l9rjl y4pRr+QoV/rDrJtB31ABnIHi2pXeEKkOOICtoEUDTZ9J4D/a8WYgxlADjz7WuR1uXGew mC6taEVEn2H5QlkA7OAg2/jIY8RYutf3XYDd4110cMjyoRK+pHgZnLnb5E6qws67raav M57x/NkPiIgNqLy90Pr6owNJt5JTJel8XIJ37NL6rE8UYoxcmoh17cqFtKrR0mSHWPCV sxbA== MIME-Version: 1.0 Received: by 10.216.85.81 with SMTP id t59mr2585984wee.28.1333658926399; Thu, 05 Apr 2012 13:48:46 -0700 (PDT) Received: by 10.216.47.68 with HTTP; Thu, 5 Apr 2012 13:48:46 -0700 (PDT) In-Reply-To: References: <20120405201542.38F56238890B@eris.apache.org> Date: Thu, 5 Apr 2012 15:48:46 -0500 Message-ID: Subject: Re: svn commit: r1310047 - /subversion/trunk/subversion/libsvn_ra/compat.c From: Hyrum K Wright To: Greg Stein Cc: dev@subversion.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQlJfBo8l2IWAnez0TsdmPgmP4PRuakCEQa2eXL8isGuD9xYm8vEkVDzJCqJmJ5PHkY98fl8 On Thu, Apr 5, 2012 at 3:29 PM, Greg Stein wrote: > On Thu, Apr 5, 2012 at 16:15, =C2=A0 wrote: >> Author: hwright >> Date: Thu Apr =C2=A05 20:15:41 2012 >> New Revision: 1310047 >> >> URL: http://svn.apache.org/viewvc?rev=3D1310047&view=3Drev >> Log: >> * subversion/libsvn_ra/compat.c >> =C2=A0(prev_log_path): Another integer-width mismatch fix. >> >> Modified: >> =C2=A0 =C2=A0subversion/trunk/subversion/libsvn_ra/compat.c >> >> Modified: subversion/trunk/subversion/libsvn_ra/compat.c >> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra/= compat.c?rev=3D1310047&r1=3D1310046&r2=3D1310047&view=3Ddiff >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- subversion/trunk/subversion/libsvn_ra/compat.c (original) >> +++ subversion/trunk/subversion/libsvn_ra/compat.c Thu Apr =C2=A05 20:15= :41 2012 >> @@ -141,7 +141,7 @@ prev_log_path(const char **prev_path_p, >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_sort__item_t item = =3D APR_ARRAY_IDX(paths, >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 i - 1, svn_sort__item_t); >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 const char *ch_path =3D= item.key; >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int len =3D strlen(ch_= path); >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0size_t len =3D strlen(= ch_path); > > size_t or should this be apr_size_t? You ask this question *every time* one of these changes is made. :P And the response usually is "apr_size_t is a typedef of size_t on every platform we support, and we already use a mix of the two throughout our code". (Of course, there's usually a bit of discussion and pedantry to get to that conclusion, and if that's what you're after, don't let me stop you. :) ) -Hyrum --=20 uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/