subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fuhrmann <eq...@web.de>
Subject Re: svn commit: r1311469 - in /subversion/trunk/subversion: include/svn_config.h libsvn_subr/config.c
Date Tue, 10 Apr 2012 15:41:09 GMT
Philip Martin wrote:
> stefan2@apache.org writes:
>
>>   svn_error_t *
>> +svn_config_get_int64(svn_config_t *cfg,
>> +                     apr_int64_t *valuep,
>> +                     const char *section,
>> +                     const char *option,
>> +                     apr_int64_t default_value)
>> +{
>> +  const char *tmp_value;
>> +  svn_config_get(cfg,&tmp_value, section, option, NULL);
>> +  if (tmp_value)
>> +    return svn_cstring_strtoui64(valuep, tmp_value,
>> +                                 APR_INT64_MIN, APR_INT64_MAX, 10);
> svn_cstring_strtoi64?
>
> svn_config_get_uint46?
>
> ../src/subversion/libsvn_subr/config.c: In function ‘svn_config_get_int64’:
> ../src/subversion/libsvn_subr/config.c:711: warning: pointer targets in passing argument
1 of ‘svn_cstring_strtoui64’ differ in signedness
> ../src/subversion/include/svn_string.h:482: note: expected ‘apr_uint64_t *’ but argument
is of type ‘apr_int64_t *’
>
A simple auto-completion artifact.
Fixed in r1311794.

Thanks for the review!
-- Stefan^2.

Mime
View raw message