subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Sperling <s...@elego.de>
Subject Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/
Date Wed, 18 Apr 2012 18:22:30 GMT
On Wed, Apr 18, 2012 at 12:33:23PM -0000, stefan2@apache.org wrote:
> Author: stefan2
> Date: Wed Apr 18 12:33:23 2012
> New Revision: 1327477
> 
> URL: http://svn.apache.org/viewvc?rev=1327477&view=rev
> Log:
> Naming policy: Rename all svn_*.c to just *.c in /subversion/libsvn_subr.

Was there a very important reason for this change?
This change can cause tree-conflicts during backports that affect
these files. It's not likely to cause a lot of harm since we're
looking at a small amount of files that rarely receive backport
changes. Still, a heads-up or question about concerns on dev@ would
have been nice since this creates extra work during backports
for no apparent gain.

A minor nit: You forgot to list svn_temp_serializer.c in the log message.

> 
> added:
> * /subversion/libsvn_subr/base64.c
> * /subversion/libsvn_subr/cache_config.c
> * /subversion/libsvn_subr/mutex.c
> * /subversion/libsvn_subr/named_atomic.c
> * /subversion/libsvn_subr/string.c
> removed:
> * /subversion/libsvn_subr/svn_base64.c
> * /subversion/libsvn_subr/svn_cache_config.c
> * /subversion/libsvn_subr/svn_mutex.c
> * /subversion/libsvn_subr/svn_named_atomic.c
> * /subversion/libsvn_subr/svn_string.c
> 
> Added:
>     subversion/trunk/subversion/libsvn_subr/base64.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_base64.c
>     subversion/trunk/subversion/libsvn_subr/cache_config.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_cache_config.c
>     subversion/trunk/subversion/libsvn_subr/mutex.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_mutex.c
>     subversion/trunk/subversion/libsvn_subr/named_atomic.c
>       - copied unchanged from r1327472, subversion/trunk/subversion/libsvn_subr/svn_named_atomic.c
>     subversion/trunk/subversion/libsvn_subr/string.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_string.c
>     subversion/trunk/subversion/libsvn_subr/temp_serializer.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_temp_serializer.c
>     subversion/trunk/subversion/libsvn_subr/types.c
>       - copied unchanged from r1327448, subversion/trunk/subversion/libsvn_subr/svn_types.c
> Removed:
>     subversion/trunk/subversion/libsvn_subr/svn_base64.c
>     subversion/trunk/subversion/libsvn_subr/svn_cache_config.c
>     subversion/trunk/subversion/libsvn_subr/svn_mutex.c
>     subversion/trunk/subversion/libsvn_subr/svn_named_atomic.c
>     subversion/trunk/subversion/libsvn_subr/svn_string.c
>     subversion/trunk/subversion/libsvn_subr/svn_temp_serializer.c
>     subversion/trunk/subversion/libsvn_subr/svn_types.c

Mime
View raw message