Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of gstein@gmail.com designates
 209.85.212.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20120206174836.DB1AC238889B@eris.apache.org>
References: <20120206174836.DB1AC238889B@eris.apache.org>
Date: Mon, 6 Feb 2012 14:28:37 -0500
Message-ID: 
 <CABD8fLUg4uoBsM58sDcGK1EyKzCExuAN4bBNABv7E-rgFnQQfw@mail.gmail.com>
Subject: Re: svn commit: r1241097 - in /subversion/trunk/subversion:
 libsvn_client/repos_diff.c libsvn_delta/compat.c libsvn_fs_base/tree.c
 libsvn_fs_fs/tree.c libsvn_wc/externals.c libsvn_wc/update_editor.c
From: Greg Stein <gstein@gmail.com>
To: dev@subversion.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 6, 2012 at 12:48,  <hwright@apache.org> wrote:
> Author: hwright
> Date: Mon Feb =A06 17:48:36 2012
> New Revision: 1241097
>
> URL: http://svn.apache.org/viewvc?rev=3D1241097&view=3Drev
> Log:
> Ev2 shims: Truthfully report our base checksum as being that of the empty
> stream.
>
> Note: This breaks several assumptions in various delta-editor receivers a=
bout
> the validity of this checksum. =A0These have been patched to ignore the c=
hecksum
> if it is that of the empty stream. =A0This will not affect correctness, a=
s the
> final checksum, as supplied by close_file() is still used to detect corru=
ption,
> and it hasn't changed.

How does this even work? Sure, the checksum isn't checked, but the
delta-editor receiver is going to choose the wrong base contents to
apply the delta against.

>...

Cheers,
-g