subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1241097 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c libsvn_delta/compat.c libsvn_fs_base/tree.c libsvn_fs_fs/tree.c libsvn_wc/externals.c libsvn_wc/update_editor.c
Date Mon, 06 Feb 2012 19:28:37 GMT
On Mon, Feb 6, 2012 at 12:48,  <hwright@apache.org> wrote:
> Author: hwright
> Date: Mon Feb  6 17:48:36 2012
> New Revision: 1241097
>
> URL: http://svn.apache.org/viewvc?rev=1241097&view=rev
> Log:
> Ev2 shims: Truthfully report our base checksum as being that of the empty
> stream.
>
> Note: This breaks several assumptions in various delta-editor receivers about
> the validity of this checksum.  These have been patched to ignore the checksum
> if it is that of the empty stream.  This will not affect correctness, as the
> final checksum, as supplied by close_file() is still used to detect corruption,
> and it hasn't changed.

How does this even work? Sure, the checksum isn't checked, but the
delta-editor receiver is going to choose the wrong base contents to
apply the delta against.

>...

Cheers,
-g

Mime
View raw message