subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthijs Kooijman <matth...@stdin.nl>
Subject Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers
Date Tue, 07 Feb 2012 20:44:52 GMT
Hey Stefan,

> Thanks. I've already committed a similar fix in r1241585.
> I wasn't quite sure if it was gonna work but glad you had the same idea :)

Actually, I just tried your fix and it doesn't work. It'll fix the build
error on win32, but it also breaks the binding on systems that do have
gnome-keyring (since the {% %} causes the declaration to be included in
the generated core.c, but it is skipped for determining what bindings to
generate (so no binding is generated in core.c).

So, you'll have to drop the {% %} (which is effectively my patch again)
;-p

Gr.

Matthijs

Mime
View raw message