Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (athena.apache.org: local policy)
From: Philip Martin <philip.martin@wandisco.com>
To: dev@subversion.apache.org
Cc: cmpilato@collab.net
Subject: Re: svn commit: r1215374 -
 /subversion/trunk/subversion/libsvn_ra_neon/log.c
References: <20111217005600.8A8712388860@eris.apache.org>
Date: Wed, 04 Jan 2012 12:46:05 +0000
In-Reply-To: <20111217005600.8A8712388860@eris.apache.org>
	(cmpilato@apache.org's message of "Sat, 17 Dec 2011 00:56:00 -0000")
Message-ID: <87ty4bk54i.fsf@stat.home.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

cmpilato@apache.org writes:

> Author: cmpilato
> Date: Sat Dec 17 00:56:00 2011
> New Revision: 1215374
>
> URL: http://svn.apache.org/viewvc?rev=3D1215374&view=3Drev
> Log:
> Followup to r1215260, just tightening up some loose logic.
>
> * subversion/libsvn_ra_neon/log.c
>   (log_start_element): Reduce the scope of the check for an encoding
>     to just those tags for which it makes sense to have one.  While
>     here, fix a long-standing potential segfault (apr_pstrdup on NULL
>     input).
>   (maybe_decode_log_cdata): Lose 'pool' parameter, and just store in
>     the result in lb->subpool.
>   (log_end_element): Update call to maybe_decode_log_cdata().

This causes log_tests.py 25 to fail with neon when built with -O2 on
my Linux box, the test passes when built -O0.  The compiler warns

../src/subversion/libsvn_ra_neon/log.c: In function =E2=80=98log_end_elemen=
t=E2=80=99:
../src/subversion/libsvn_ra_neon/log.c:293: warning: =E2=80=98decoded_cdata=
=E2=80=99 may be used uninitialized in this function

but that may not be the cause since the patch below doesn't fix the
fail:

Index: subversion/libsvn_ra_neon/log.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- subversion/libsvn_ra_neon/log.c	(revision 1227106)
+++ subversion/libsvn_ra_neon/log.c	(working copy)
@@ -292,8 +292,7 @@
   struct log_baton *lb =3D baton;
   const svn_string_t *decoded_cdata;
=20
-  if (lb->want_cdata)
-    SVN_ERR(maybe_decode_log_cdata(&decoded_cdata, lb));
+  SVN_ERR(maybe_decode_log_cdata(&decoded_cdata, lb));
=20
   switch (state)
     {

--=20
Philip