From dev-return-8240-daniel=haxx.se@subversion.apache.org Wed Dec 8 16:58:09 2010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on giant.haxx.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by giant.haxx.se (8.14.3/8.14.3/Debian-9.1) with SMTP id oB8Fw7Ji009318 for ; Wed, 8 Dec 2010 16:58:08 +0100 Received: (qmail 76807 invoked by uid 500); 8 Dec 2010 15:58:00 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 76799 invoked by uid 99); 8 Dec 2010 15:57:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 15:57:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS Received-SPF: pass (athena.apache.org: domain of jcorvel@gmail.com designates 209.85.213.43 as permitted sender) Received: from [209.85.213.43] (HELO mail-yw0-f43.google.com) (209.85.213.43) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 15:57:55 +0000 Received: by yws5 with SMTP id 5so739478yws.16 for ; Wed, 08 Dec 2010 07:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=3gdcmwfwyRX49EpN0/W+JdLWi+CFOiyLJIWzBKOdMwk=; b=H9IibIU7mgXCZ6KJuX0kRTJzH/zOpah7I2OmZK1jmjQf6gQes6Ia8NNma30kscG3DQ ov8oXB+YRaNI01K8KGiP0A4khEcuX4NNqEc+oZr13Tb5E2dlb1KYXtiN8c70057grpuG 1jesq9efC6zM01Tn4q1gA8JvjQ7QuiQbX/aZA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=sQ3orrrtH7F1g6eQ7pdf26akF1mGyGEQTNLl3/ygXKQ6ssWvMiK2+KlO+cpKC2M1Rx SOZByAIArv9M1acodJVVcyuta88rYcEMEOXWVxn02dSDGwNEy6RLvM0dfcKvbFg+yZ+/ ZOHOe/nBAISSE5KBBiYpTrl2CRG++BVSK20Yc= Received: by 10.231.11.139 with SMTP id t11mr814441ibt.66.1291823854033; Wed, 08 Dec 2010 07:57:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.14.75 with HTTP; Wed, 8 Dec 2010 07:57:13 -0800 (PST) In-Reply-To: <1291817824.2297.1314.camel@edith> References: <1291817824.2297.1314.camel@edith> From: Johan Corveleyn Date: Wed, 8 Dec 2010 16:57:13 +0100 Message-ID: Subject: Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to verify issue #3429 To: Julian Foad Cc: Subversion Development Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.3.5 (giant.haxx.se [80.67.6.50]); Wed, 08 Dec 2010 16:58:09 +0100 (CET) X-Friend: Nope On Wed, Dec 8, 2010 at 3:17 PM, Julian Foad wrot= e: > On Wed, 2010-11-17, Johan Corveleyn wrote: >> On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn wro= te: >> > The attached patch expands the test "move_file_back_and_forth" >> > (copy_tests.py 45) as a regression test for issue#3429. > [...] >> I just realized that I can add a similar check to >> move_dir_back_and_forth. Here is a second patch that expands both >> tests. > > Thank you, Johan. =A0Committed revision 1043427. =A0(I tweaked the commen= ts > a bit.) > > I have closed issue #3429. Thanks! >> (note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped >> from move_dir_back_and_forth?) > > Because single-db is now always enabled? =A0Yes. =A0But it's sometimes ni= ce > to be able to go back and test older code with the current tests, so > let's not hurry to remove it. Ok, got it. Cheers, --=20 Johan