subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <philip.mar...@wandisco.com>
Subject Re: svn commit: r1040832 - Port a fix for a FSFS packing race
Date Mon, 06 Dec 2010 18:44:52 GMT
Julian Foad <julian.foad@wandisco.com> writes:

> I'm going to drop this "Remove the re-try logic from
> svn_fs_fs__path_rev_absolute()" follow-up patch, as I don't want to get
> into checking or messing with the txn-correctness of FSFS now.  If
> Daniel or anyone else wants to pursue it, I'd be glad to help.

I thought the patch was an improvement.  The existing retry in
svn_fs_fs__path_rev_absolute doesn't fix the race, it simply makes the
window smaller.  As the patch makes the window larger we are more likely
to see and fix any places where the caller doesn't handle the race.

-- 
Philip

Mime
View raw message