subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <>
Subject Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)
Date Tue, 07 Dec 2010 15:58:00 GMT
David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 09:30:45 -0600:
> On Tue, December 7, 2010 09:03, Daniel Shahaf wrote:
> > David Dyer-Bennet wrote on Tue, Dec 07, 2010 at 08:44:28 -0600:
> >> And, in any case, VISUAL is a public interface, and I wonder how many
> >> other applications would break if I put that kind of thing into
> >> VISUAL.
> >
> > Morale: don't use paths with spaces.
> Yes, that would be simpler.  But as I said in my initial post, I first
> discovered this on Windows under Cygwin.  Avoiding "c:/Program Files"
> and "c:/Documents and Settings/david.dyer-bennet/My Documents"
> involves contortions and leaves you putting things in unusual places.

Just create a symlink in cygwin?

> Linux defines spaces as valid characters in paths and filenames, so
> people are going to try to use them.  And Subversion does support
> Windows.

Newline, tab, and colon are also valid in on linux, and I'm sure some
parts of Subversion will not work properly if you use them.  (Do we
URI-encode paths in svn:mergeinfo and 'svn diff'?)

> (Spelling nit, no flame intended:  "moral"; not "morale".  They're
> both real words with quite different meanings, so it's of value to
> keep them distinct.  And now I have no doubt guaranteed 3 basic
> language mistakes of my own somewhere in this message :-) .)

Thanks for the correction; appreciated.

(Shouldn't you have spelled out 'three'?  Just yesterday I found a bug
related to using 'two' instead of '2'.)

View raw message