subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: Bug report -- space in env. var. VISUAL causes commits to fail (needs confirmation)
Date Tue, 07 Dec 2010 08:23:37 GMT
CC += dev@

Daniel Näslund wrote on Mon, Dec 06, 2010 at 21:32:39 +0100:
> On Mon, Dec 06, 2010 at 01:44:23PM -0600, David Dyer-Bennet wrote:
> > Subversion 1.6.12 running on Centos 5.5
> > 
> > If the value of the environment variable VISUAL contains a space,
> > subversion fails when attempting to invoke the editor to get the
> > comment.
> > 
> > sh-3.2$ export VISUAL="/home/spaces in name/bin/emacs"
> > sh-3.2$ svn commit
> > sh: /home/spaces: No such file or directory
> > svn: Commit failed (details follow):
> > svn: system('/home/spaces in name/bin/emacs svn-commit.tmp') returned 32512
> > 
> > As you see in the error, it's constructing a command string without
> > consideration of the possibility of spaces in various places.
> 
> [...]
> 
> > So, can somebody confirm this please?  And, ideally, submit the bug
> > (since I keep getting stuck trying to go through all the hoops they
> > want you to go through to become enabled to do that)?
> 
> Found this thread [1] that discusses spaces in the editor cmd string. Julian
> Foad confirms that it's a bug in a follow-up and even has some
> suggestions on how to tackle the problem if someone wants to write a
> patch.

Today we use system(), and thus things like EDITOR='gvim -f' and
EDITOR='emacs -nw' work.  If propedit-cmd.c just quoted all spaces in
the editor command, it would break this use case.

I suppose setting VISUAL="\"/path with spaces/to/editor/binary\"" is the
easiest solution --- it requires no code changes so it will work with
any svn binary out there.

> I haven't found any issues related to the problem in the
> tracker but I'm really loosy when it comes to using issue trackers.
> 
> Daniel
> 
> [1] http://svn.haxx.se/dev/archive-2010-02/0051.shtml
> 

Mime
View raw message