subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: diff-optimizations-tokens branch: I think I'm going to abandon it
Date Thu, 02 Dec 2010 20:59:29 GMT
Johan Corveleyn wrote on Thu, Dec 02, 2010 at 21:21:20 +0100:
> On Thu, Dec 2, 2010 at 6:18 PM, Bill Tutt <bill@tutts.org> wrote:
> >    If tokens include keyword expansion operations then stop once you
> > hit one. The possible source of bugs outways the perf gain in my mind
> > here.
> 
> Haven't thought about keyword expansion yet. But as you suggest: I'm
> not going to bother doing special stuff for (expanded) keywords. If we
> find a mismatch, we'll stop with the optimized scanning, and fall back
> to the default algorithm.

Only for the suffix scanning?  Or also for the prefix scanning?

(I think you meant the former.)  For prefix scanning, I think it's
common to have $Id$ or similar near the top of the file, so being able
to collect matching lines past it too would be beneficial.

Mime
View raw message