subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1041102 - /subversion/trunk/subversion/include/svn_io.h
Date Thu, 02 Dec 2010 05:55:29 GMT
julianfoad@apache.org wrote on Wed, Dec 01, 2010 at 17:44:50 -0000:
> Author: julianfoad
> Date: Wed Dec  1 17:44:49 2010
> New Revision: 1041102
> 
> URL: http://svn.apache.org/viewvc?rev=1041102&view=rev
> Log:
> * subversion/include/svn_io.h
>   (svn_io_dir_file_copy): Clarify the doc string.
> 
> Modified:
>     subversion/trunk/subversion/include/svn_io.h
> 
> Modified: subversion/trunk/subversion/include/svn_io.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_io.h?rev=1041102&r1=1041101&r2=1041102&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/include/svn_io.h (original)
> +++ subversion/trunk/subversion/include/svn_io.h Wed Dec  1 17:44:49 2010
> @@ -692,8 +692,11 @@ svn_error_t *
>  svn_io_file_flush_to_disk(apr_file_t *file,
>                            apr_pool_t *pool);
>  
> -/** Copy file @a file from location @a src_path to location @a dest_path.
> - * Use @a pool for memory allocations.
> +/** Copy the file whose basename or relative path is @a file within
> + * directory @a src_path to the same basename or relative path within
> + * directory @a dest_path.  Overwrite the destination if it already

If you allow relative paths as input for @a file, then shouldn't the
docstring say whether or not this creates intermediate directories?

Example: svn_io_dir_file_copy('A/B', 'A/C', 'E/alpha', NULL).

> + * exists.  Set the destination file's permissions to match those of
> + * the source.  Use @a pool for memory allocations.
>   */
>  svn_error_t *
>  svn_io_dir_file_copy(const char *src_path,
>                       const char *dest_path,
>                       const char *file,
>                       apr_pool_t *pool)
> 
> 

Mime
View raw message