subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1040663 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c
Date Wed, 01 Dec 2010 03:41:06 GMT
julianfoad@apache.org wrote on Tue, Nov 30, 2010 at 18:07:52 -0000:
> +  /* Remove each remaining pristine that is listed in SHA1S. */
> +  for (hi = apr_hash_first(scratch_pool, sha1s);
> +       hi; hi = apr_hash_next(hi))
> +    {
> +      const unsigned char *sha1_digest = svn__apr_hash_index_key(hi);
> +      const svn_checksum_t *sha1_checksum
> +        = svn_checksum__from_digest(sha1_digest, svn_checksum_sha1,
> +                                    scratch_pool);
> +
> +      SVN_ERR(pristine_remove(pdh, sha1_checksum, scratch_pool));
> +    }

So we loop over the remaining sha1's and remove each of them...
I wonder if there is room for further optimization here?  e.g., does
this prepare/reset the statement just once, or once per iteration?

Daniel
(I hope the question makes sense --- I'm not very familiar with
the svn_sqlite__* API)

Mime
View raw message