subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <>
Subject Re: [Merge request] Merge r985477 from performance branch
Date Mon, 04 Oct 2010 09:32:50 GMT
On Sun, 2010-10-03, Ramkumar Ramachandra wrote:
> Hi Julian,
> Julian Foad writes:
> > Looks good to me.
> > 
> > I wondered if it is safe in a long-running Subversion process, like
> > TortoiseSvn or a Linux equivalent.
> > 
> > It seems to me that it won't really matter much in practice.  If someone
> > changes their umask and finds that Subversion carries on creating files
> > with the 'old' permissions that were in effect when Subversion was
> > started... that's fine, as far as I'm concerned.
> Can I get an explicit +1 to commit this? I just want to get as many of
> Stefan's changes merged in quickly so that there's enough time before
> the 1.7 release to test them.

Hi Ram.  I wasn't comfortable with giving a +1 for this change just
then, but now I've satisfied myself.  The only potential negative impact
I can imagine is if a user has a very long-running instance of
Subversion and is accustomed to Subversion tracking changes of umask.
To such a user, this might be seen as a regression, but the impact on
such a user is low.  In all other respects, determining the permissions
just once per execution is more correct as well as more efficient.

+1 to merge, with minor tweaks if you wish.

- Julian

View raw message