subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: opening fsfs rev files rw
Date Tue, 03 Aug 2010 15:43:38 GMT
> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s@daniel.shahaf.name]
> Sent: dinsdag 3 augustus 2010 17:20
> To: dev@subversion.apache.org
> Subject: Re: opening fsfs rev files rw
> 
> Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:32 +0300:
> > There was yesterday on IRC [1] some discussion around whether revprop
> > editing can corrupt rev files.
> >
> > [[[
> > 0:% rm -rf r
> > 0:% ./subversion/svnadmin/svnadmin create r
> > 0:% ls -l r/db/revs/0/0
> > -rw-r--r-- 1 daniel daniel 115 2010-08-03 11:56 r/db/revs/0/0
> > ]]]
> >
> > Shouldn't we create rev files with the write bit disabled?  (i.e.,
> 0222 umask)
> >
> 
> r981921 + nominated for backport.

I'm not sure whether this really helps. What I suggested on IRC, was that we
shouldn't open the files for read-write, but only for reading (where I just
tried to get confirmation that we did)

This patch just makes us a tiny bit slower and makes it a bit harder for
third party tools to corrupt the repository.


One other thing: How does 'svnadmin pack' handle this?

If it can't handle this we might have to delay this to the first format
bump.

	Bert


Mime
View raw message