From dev-return-4194-daniel=haxx.se@subversion.apache.org Thu Jun 3 23:36:23 2010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on giant.haxx.se X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DS_FRIEND, FREEMAIL_FROM,T_DKIM_INVALID,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=ham version=3.3.1 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by giant.haxx.se (8.14.3/8.14.3/Debian-9.1) with SMTP id o53LaM0g020337 for ; Thu, 3 Jun 2010 23:36:23 +0200 Received: (qmail 13993 invoked by uid 500); 3 Jun 2010 21:36:12 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 13985 invoked by uid 99); 3 Jun 2010 21:36:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 21:36:12 +0000 X-ASF-Spam-Status: No, hits=-0.5 required=10.0 tests=AWL,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL Received-SPF: pass (athena.apache.org: domain of gstein@gmail.com designates 209.85.212.43 as permitted sender) Received: from [209.85.212.43] (HELO mail-vw0-f43.google.com) (209.85.212.43) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 21:36:06 +0000 Received: by vws3 with SMTP id 3so785225vws.16 for ; Thu, 03 Jun 2010 14:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=pjbP0FmANaxK3yqgilmESThblI5VHhqaJZQtt4FNEPQ=; b=Y13NEkPIVcv4p+NTwTX+cLJVR7oJZRlt5a8nhdlav7Iin/vsGdg3Swo7pgptm3honI kRhKFm9IU4ckIW3h0zRX0a+6yufxmbj2Jk//Zujaq9J3uvYoUF5zQ3O4m/i+lPkNe+Ud NGv6/IcJfYHaTkXGy1X5BMx1mzMNjfJZ0RBKk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=laiheMBJCAmcA4bmLWylCuVNwHLHgHSEMz8u6w7RuLVQfWb7X+nwNyhAf8irtitc4P l3/4AcPRYQ6Y1sZkXQxCpEPq8VnUFbvyoDtZX2cxTOQfmHPwWsHHVb98Wj3MD2vZuN8Q NmmgGpXXNk8T/r2a9edlNQDJpi+MiDycoayBo= MIME-Version: 1.0 Received: by 10.224.126.194 with SMTP id d2mr5557098qas.265.1275600945441; Thu, 03 Jun 2010 14:35:45 -0700 (PDT) Received: by 10.229.250.1 with HTTP; Thu, 3 Jun 2010 14:35:45 -0700 (PDT) In-Reply-To: <20100531193653.AFFC1238890D@eris.apache.org> References: <20100531193653.AFFC1238890D@eris.apache.org> Date: Thu, 3 Jun 2010 17:35:45 -0400 Message-ID: Subject: Re: svn commit: r949842 - /subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp From: Greg Stein To: dev@subversion.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.3.5 (giant.haxx.se [80.67.6.50]); Thu, 03 Jun 2010 23:36:23 +0200 (CEST) X-Friend: Friend Log msg has the wrong func names... On Mon, May 31, 2010 at 15:36, wrote: > Author: hwright > Date: Mon May 31 19:36:53 2010 > New Revision: 949842 > > URL: http://svn.apache.org/viewvc?rev=3D949842&view=3Drev > Log: > Fix a double free in the JavaHL bindings. > > Patch by: Byeongcheol Lee > > * subversion/bindings/javahl/native/CopySources.cpp > =A0(array): Replace JNIStringHolder() with two calls to GetStringUTFChars= () > =A0 =A0and DeleteLocalRef(). > > Modified: > =A0 =A0subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp > > Modified: subversion/trunk/subversion/bindings/javahl/native/CopySources.= cpp > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/ja= vahl/native/CopySources.cpp?rev=3D949842&r1=3D949841&r2=3D949842&view=3Ddif= f > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp (o= riginal) > +++ subversion/trunk/subversion/bindings/javahl/native/CopySources.cpp Mo= n May 31 19:36:53 2010 > @@ -116,11 +116,12 @@ CopySources::array(SVN::Pool &pool) > =A0 =A0 =A0 if (JNIUtil::isJavaExceptionThrown()) > =A0 =A0 =A0 =A0 return NULL; > > - =A0 =A0 =A0JNIStringHolder path(jpath); > + =A0 =A0 =A0const char *path =3D env->GetStringUTFChars(jpath, NULL); > =A0 =A0 =A0 if (JNIUtil::isJavaExceptionThrown()) > =A0 =A0 =A0 =A0 return NULL; > > - =A0 =A0 =A0src->path =3D apr_pstrdup(p, (const char *) path); > + =A0 =A0 =A0src->path =3D apr_pstrdup(p, path); > + =A0 =A0 =A0env->ReleaseStringUTFChars(jpath, path); > =A0 =A0 =A0 SVN_JNI_ERR(JNIUtil::preprocessPath(src->path, pool.pool()), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 NULL); > =A0 =A0 =A0 env->DeleteLocalRef(jpath); > > >