subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject RE: Subversion Compile/Test on HPUX11.11: How to review/resolve make check results?
Date Tue, 08 Jun 2010 04:52:44 GMT
Julian Foad wrote on Tue, 8 Jun 2010 at 02:29 -0000:
>   1. The test suite sets the environment variable SVN_EDITOR to
> os.path.join(sys.path[0], 'svneditor.py'), i.e.
> 'subversion/tests/cmdline/svneditor.py'.

We could also set it to

    sys.executable + space + 'subversion/tests/cmdline/svneditor.py'
    (+ appropriate quoting)

I had to do the same for windows (see use of envvar SVN_TEST_PYTHON)
a long time ago, for the same reason you speculate below.

It'd be something like this (but less crude than it):

[[[
Index: subversion/tests/cmdline/svntest/main.py
===================================================================
--- subversion/tests/cmdline/svntest/main.py	(revision 951533)
+++ subversion/tests/cmdline/svntest/main.py	(working copy)
@@ -119,7 +119,7 @@
 if windows:
   svneditor_script = os.path.join(sys.path[0], 'svneditor.bat')
 else:
-  svneditor_script = os.path.join(sys.path[0], 'svneditor.py')
+  svneditor_script = "'%s' '%s'" % (sys.executable, os.path.join(sys.path[0], 'svneditor.py'))
 
 # Username and password used by the working copies
 wc_author = 'jrandom'
]]]

Daniel

>   2. "svn propedit" will execute the program named in SVN_EDITOR.
>   3. "svneditor.py" looks at the environment variable
> SVNTEST_EDITOR_FUNC and executes the Python function named therein.
>   4. The Python function foo_to_bar() (defined in svneditor.py) does the
> foo-to-bar text substitution.
> 
> So the problem might well be something to do with environment variables
> or running external scripts on your system.  Is 'svneditor.py' marked as
> executable?  It should be.  That's probably the problem.

Mime
View raw message