subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r949964 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Date Thu, 03 Jun 2010 16:53:41 GMT
On Tue, Jun 1, 2010 at 08:40, Philip Martin <philip.martin@wandisco.com> wrote:
> "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu> writes:
>
>>>  scratch_pool);
>>> -      const char *properties = svn_sqlite__column_text(stmt, 6,
>>> scratch_pool);
>>> +      apr_size_t props_size;
>>> +      const char *properties = svn_sqlite__column_blob(stmt, 6,
>>> &props_size,
>>> +                                                  
    scratch_pool);
>>>
>>
>> Should we be using svn_sqlite__column_properties() here (and extending
>> _bindf() so that it knows about properties)?  I understand we're just doing
>> a straight copy, so we don't necessarily need to parse and unparse the
>> properties, but if this is the case, perhaps a comment in the code would be
>> useful.
>

It is still nice to have a comment that the properties are being
passed as an unserialized blob. That code will live for another couple
months (probably), and who knows how many times it will be read (or
copied or referred to as an example) in the meantime.

Cheers,
-g

Mime
View raw message