From dev-return-3012-daniel=haxx.se@subversion.apache.org Wed Mar 31 19:48:29 2010 Return-Path: Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by giant.haxx.se (8.14.3/8.14.3/Debian-9) with SMTP id o2VHmS5L001670 for ; Wed, 31 Mar 2010 19:48:29 +0200 Received: (qmail 84447 invoked by uid 500); 31 Mar 2010 17:48:29 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 84439 invoked by uid 99); 31 Mar 2010 17:48:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Mar 2010 17:48:29 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL,UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [68.142.198.202] (HELO smtp103.sbc.mail.mud.yahoo.com) (68.142.198.202) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 31 Mar 2010 17:48:21 +0000 Received: (qmail 28454 invoked from network); 31 Mar 2010 17:47:59 -0000 Received: from wire.p12n.org (peters@208.190.253.74 with login) by smtp103.sbc.mail.mud.yahoo.com with SMTP; 31 Mar 2010 10:47:59 -0700 PDT X-Yahoo-SMTP: I7_sUP.swBD648cpeap5UkBNBhuulx8OBWgX4uMszg-- X-YMail-OSG: hjb.jSMVM1krawAEx41wCMRlTZoY0CxRyXk6y4DPIYcmpzOm65UnMu8RPV6GhOdgUMSKm_gzbJgx_L6nF7J1GZ.PCj3LLtu_p9Juf1h6x40kmnrlaWs4fXjg0OnImMR5J64zgVGs72ISowUbK5Sibsbr.qkmKARbE6mjP85hIVRvipR3gDnbZQu0LRZbV5ZiJnpoDPzLNz2efS9z9JM1zmjvFFz3X7xuuik_6Upo57T3X.pq.7xJ46iB57htMq1_ X-Yahoo-Newman-Property: ymail-3 Received: by wire.p12n.org (Postfix, from userid 1001) id LMyskG7XIe; Wed, 31 Mar 2010 12:47:59 -0500 (CDT) Date: Wed, 31 Mar 2010 12:47:59 -0500 From: Peter Samuelson To: dev@subversion.apache.org Subject: Re: svn commit: r929382 - /subversion/branches/1.6.x-wc-ng-error/subversion/libsvn_wc/questions.c Message-ID: <20100331174759.GY3763@p12n.org> References: <20100331051345.2724C2388980@eris.apache.org> <20100331163242.GX3763@p12n.org> <000001cad0f4$1090c080$31b24180$@nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001cad0f4$1090c080$31b24180$@nl> User-Agent: Mutt/1.5.20 (2009-06-14) X-Virus-Checked: Checked by ClamAV on apache.org [Bert Huijben] > > > > wc_db_path = svn_path_join_many(pool, abspath, > > SVN_WC_ADM_DIR_NAME, > > > > "wc.db", NULL); > > > > > > Shouldn't this use svn_wc_get_adm_dir()? > > > > Probably ... but since this is 1.6-specific code (it is not and never > > will be in trunk), I think we'd need a good reason to bother changing > > it. > > Is the common use of "_svn" by setting an environment variable, on > Windows a good enough reason for you? Yes, that would be a good reason. But as Julian noted on IRC, it's a separate bugfix, so please patch and propose it separately. Peter