subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <philip.mar...@wandisco.com>
Subject Re: [PATCH] wc-ng - Remove use of entry_t from calculate_target_mergeinfo
Date Tue, 02 Mar 2010 11:16:05 GMT
Matthew Bentham <mjb67@artvps.com> writes:

>> Perhaps calculate_target_mergeinfo should simply call _scan_addition
>> to get the added/copied/moved status?
>
> It could do, but _scan_addition is private to libsvn_wc right now, like
> _read_info (and indeed _status_copied and the other status
> enumerations).

Ok. I didn't spot that.

>  I understood the plan to be that for now we add small
> routines that call __db routines internally?

That still leaves the question about _status_moved_here.  The original
code checked entry->copied and I think that would have included moves,
since they were just copy+delete, I think you will need
svn_wc__node_is_status_moved as well.  Perhaps svn_wc__node_get_status
would be better?

-- 
Philip

Mime
View raw message