subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <philip.mar...@wandisco.com>
Subject Re: Ruby test failure on 1.6.x
Date Tue, 12 Jan 2010 09:23:29 GMT
Joe Swatosh <joe.swatosh@gmail.com> writes:

> On Mon, Jan 11, 2010 at 12:01 PM, Hyrum K. Wright
> <hyrum_wright@mail.utexas.edu> wrote:
>>
>> On Jan 11, 2010, at 12:12 PM, Philip Martin wrote:
>>
>>> "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu> writes:
>>>
>>>> After merging the pending fixes into 1.6.x, I reran the tests.  The only
failure was in the ruby bindings:
>>>>
>>>> [[[
>>>> hwright@orac:~/dev/svn-1.6.x$ make check-swig-rb
>>>> cd /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby; \
>>>>        /usr/bin/ruby -I /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby
\
>>>>          /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby/test/run-test.rb
\
>>>>          --verbose=normal
>>>> Loaded suite .
>>>> Started
>>>> ...................................................................................................................E.......................................................................................................
>>>> Finished in 18.84964 seconds.
>>>>
>>>>  1) Error:
>>>> test_apply(SvnDeltaTest):
>>>> ArgumentError: NULL pointer given
>>>> /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_txdelta_apply_wrapper'
>>>> /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby/svn/util.rb:86:in
`txdelta_apply_wrapper'
>>>> /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby/svn/delta.rb:54:in
`apply'
>>>> /home/hwright/dev/svn-1.6.x/subversion/bindings/swig/ruby/test/test_delta.rb:128:in
`test_apply'
>>>>
>>>> 219 tests, 1490 assertions, 0 failures, 1 errors
>>>> make: *** [check-swig-rb] Error 1
>>>> ]]]
>>>
>>> On my debian stable box using r897912 with ruby-1.8.7, swig-1.3.36 and
>>> gcc-4.3.2 I get no failures.  It takes 528 seconds rather than 18.8.
>>
>> If Joe can not reproduce, we'll chalk it up to local issues and I'll proceed with
the release.
>>
>
> All the tests are passing for me.
>
> But this sounded kinda familiar.  The wc-ng work on trunk has exposed
> a lot of places where the bindings or the tests of the bindings have
> had pool lifetime related issues.

I build with pool debugging enabled. I have run the tests under
valgrind as follows:

(cd subversion/bindings/swig/ruby && valgrind ruby -I ../../../../../src-1.6/subversion/bindings/swig/ruby
../../../../../src-1.6/subversion/bindings/swig/ruby/test/run-test.rb test_delta.rb)

I get a variety of valgrind assertions during the initialisation
phase, but during the tests I get:

==19064== Use of uninitialised value of size 8
==19064==    at 0x4C6CB78: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C6C69E: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C6CF46: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C6D8FA: rb_gc (in /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C6D918: rb_gc_start (in /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C586C1: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C58829: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C527DF: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C569BA: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C52BD7: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C55A9E: (within /usr/lib/libruby1.8.so.1.8.7)
==19064==    by 0x4C58577: (within /usr/lib/libruby1.8.so.1.8.7)
...........
Finished in 34.863395 seconds.

11 tests, 49 assertions, 0 failures, 0 errors

The error occurs in test_apply which I assume is the sixth dot in that
list; there are no valgrind assertions associated with that particular
test.

-- 
Philip

Mime
View raw message