subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "C. Michael Pilato" <cmpil...@collab.net>
Subject Re: Bdb strings anomaly
Date Wed, 13 Jan 2010 13:03:47 GMT
Vadim Chekan wrote:
> I'm not sure how to solve it. One way is to modify
> svn_fs_base__get_mutable_rep to create new keys without saving
> strings/representations tables.
> Another way is to return new unsaved string/representation implying
> that consequent calls will modify representation and save it.

Vadim, thanks for the deep dive into the code.  Without diving in myself,
let me just say that we have plenty of precedent in the BDB backend for
reserving a key ID without actually storing a row of data keyed on that ID.
 So perhaps you've nailed exactly the right fix for this -- teach the code
to reserve IDs without storing data behind them until there's real data to
add, and of course teach it also not to freak out when dealing with such a
data-less key unless the code knows there should have been something stored
there already.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand


Mime
View raw message