From commits-return-49111-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Fri Jul 20 18:06:13 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CC1A1180663 for ; Fri, 20 Jul 2018 18:06:12 +0200 (CEST) Received: (qmail 59675 invoked by uid 500); 20 Jul 2018 16:06:11 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 59665 invoked by uid 99); 20 Jul 2018 16:06:11 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 16:06:11 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 66C8C3A0041 for ; Fri, 20 Jul 2018 16:06:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1836368 - /subversion/trunk/subversion/libsvn_client/repos_diff.c Date: Fri, 20 Jul 2018 16:06:11 -0000 To: commits@subversion.apache.org From: julianfoad@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20180720160611.66C8C3A0041@svn01-us-west.apache.org> Author: julianfoad Date: Fri Jul 20 16:06:11 2018 New Revision: 1836368 URL: http://svn.apache.org/viewvc?rev=1836368&view=rev Log: Fix libsvn_client 'repos-diff' which was incompletely filtering out no-op property changes since r1097039. Tested by temporarily inserting postcondition assertions. * subversion/libsvn_client/repos_diff.c (remove_non_prop_changes): Remove all redundant prop changes, not just some of them. Modified: subversion/trunk/subversion/libsvn_client/repos_diff.c Modified: subversion/trunk/subversion/libsvn_client/repos_diff.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/repos_diff.c?rev=1836368&r1=1836367&r2=1836368&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_client/repos_diff.c (original) +++ subversion/trunk/subversion/libsvn_client/repos_diff.c Fri Jul 20 16:06:11 2018 @@ -413,6 +413,7 @@ remove_non_prop_changes(apr_hash_t *pris = APR_ARRAY_IDX(changes, j+1, svn_prop_t); } changes->nelts--; + i--; } } }