Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E96C2200D54 for ; Fri, 24 Nov 2017 05:00:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E7B4B160C10; Fri, 24 Nov 2017 04:00:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3A014160BFE for ; Fri, 24 Nov 2017 05:00:18 +0100 (CET) Received: (qmail 45906 invoked by uid 500); 24 Nov 2017 04:00:17 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 45894 invoked by uid 99); 24 Nov 2017 04:00:17 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2017 04:00:17 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id C3B243A0118 for ; Fri, 24 Nov 2017 04:00:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1816207 - in /subversion/branches/1.8.x: ./ STATUS subversion/ subversion/svnrdump/dump_editor.c Date: Fri, 24 Nov 2017 04:00:12 -0000 To: commits@subversion.apache.org From: svn-role@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20171124040014.C3B243A0118@svn01-us-west.apache.org> archived-at: Fri, 24 Nov 2017 04:00:19 -0000 Author: svn-role Date: Fri Nov 24 04:00:12 2017 New Revision: 1816207 URL: http://svn.apache.org/viewvc?rev=1816207&view=rev Log: Merge the 1.8.x-issue4707 branch: * r1816069,1816106 Issue #4707: svnrdump dump: 2GB limit on content-length header. Justification: Large file support is broken in svnrdump <= 1.8. Notes: Only <= 1.8.x was broken; 1.9.x uses refactored code without the bug. Ideally we'd add a regression test; I'll leave that decision to reviewers. Branch: 1.8.x-issue4707 Votes: +1: julianfoad, luke1410, rhuijben Modified: subversion/branches/1.8.x/ (props changed) subversion/branches/1.8.x/STATUS subversion/branches/1.8.x/subversion/ (props changed) subversion/branches/1.8.x/subversion/svnrdump/dump_editor.c Propchange: subversion/branches/1.8.x/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Nov 24 04:00:12 2017 @@ -15,6 +15,7 @@ /subversion/branches/1.8.x-issue4554-v2:1678055-1740290 /subversion/branches/1.8.x-issue4557:1719351-1770605 /subversion/branches/1.8.x-issue4658:1766593-1770612 +/subversion/branches/1.8.x-issue4707:1816068-1816206 /subversion/branches/1.8.x-javahl-exception-crash:1586424-1588151 /subversion/branches/1.8.x-libsvnjavahl-version:1483910-1485054 /subversion/branches/1.8.x-memory-fragmentation:1669948-1701344 Modified: subversion/branches/1.8.x/STATUS URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/STATUS?rev=1816207&r1=1816206&r2=1816207&view=diff ============================================================================== --- subversion/branches/1.8.x/STATUS (original) +++ subversion/branches/1.8.x/STATUS Fri Nov 24 04:00:12 2017 @@ -48,15 +48,3 @@ Veto-blocked changes: Approved changes: ================= - - * r1816069,1816106 - Issue #4707: svnrdump dump: 2GB limit on content-length header. - Justification: - Large file support is broken in svnrdump <= 1.8. - Notes: - Only <= 1.8.x was broken; 1.9.x uses refactored code without the bug. - Ideally we'd add a regression test; I'll leave that decision to reviewers. - Branch: - 1.8.x-issue4707 - Votes: - +1: julianfoad, luke1410, rhuijben Propchange: subversion/branches/1.8.x/subversion/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Nov 24 04:00:12 2017 @@ -14,6 +14,7 @@ /subversion/branches/1.8.x-issue4554-v2/subversion:1678055-1740290 /subversion/branches/1.8.x-issue4557/subversion:1719351-1770605 /subversion/branches/1.8.x-issue4658/subversion:1766593-1770612 +/subversion/branches/1.8.x-issue4707/subversion:1816068-1816206 /subversion/branches/1.8.x-javahl-exception-crash/subversion:1586424-1588151 /subversion/branches/1.8.x-libsvnjavahl-version/subversion:1483910-1485054 /subversion/branches/1.8.x-memory-fragmentation/subversion:1669948-1701344 Modified: subversion/branches/1.8.x/subversion/svnrdump/dump_editor.c URL: http://svn.apache.org/viewvc/subversion/branches/1.8.x/subversion/svnrdump/dump_editor.c?rev=1816207&r1=1816206&r2=1816207&view=diff ============================================================================== --- subversion/branches/1.8.x/subversion/svnrdump/dump_editor.c (original) +++ subversion/branches/1.8.x/subversion/svnrdump/dump_editor.c Fri Nov 24 04:00:12 2017 @@ -1040,8 +1040,8 @@ close_file(void *file_baton, /* Text-content-length: 39 */ SVN_ERR(svn_stream_printf(eb->stream, pool, SVN_REPOS_DUMPFILE_TEXT_CONTENT_LENGTH - ": %lu\n", - (unsigned long)info->size)); + ": %" APR_OFF_T_FMT "\n", + info->size)); /* Text-content-md5: 82705804337e04dcd0e586bfa2389a7f */ SVN_ERR(svn_stream_printf(eb->stream, pool, @@ -1055,13 +1055,13 @@ close_file(void *file_baton, if (fb->dump_props) SVN_ERR(svn_stream_printf(eb->stream, pool, SVN_REPOS_DUMPFILE_CONTENT_LENGTH - ": %ld\n\n", - (unsigned long)info->size + propstring->len)); + ": %" APR_OFF_T_FMT "\n\n", + info->size + propstring->len)); else if (fb->dump_text) SVN_ERR(svn_stream_printf(eb->stream, pool, SVN_REPOS_DUMPFILE_CONTENT_LENGTH - ": %ld\n\n", - (unsigned long)info->size)); + ": %" APR_OFF_T_FMT "\n\n", + info->size)); /* Dump the props now */ if (fb->dump_props)