subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject svn commit: r1806818 - /subversion/trunk/subversion/libsvn_subr/spillbuf.c
Date Thu, 31 Aug 2017 16:01:57 GMT
Author: brane
Date: Thu Aug 31 16:01:57 2017
New Revision: 1806818

URL: http://svn.apache.org/viewvc?rev=1806818&view=rev
Log:
Update documentation. No functional change.

* subversion/libsvn_subr/spillbuf.c (svn_spillbuf__write):
   Update comment in the spill-all-contents branch.

Modified:
    subversion/trunk/subversion/libsvn_subr/spillbuf.c

Modified: subversion/trunk/subversion/libsvn_subr/spillbuf.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/spillbuf.c?rev=1806818&r1=1806817&r2=1806818&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/spillbuf.c (original)
+++ subversion/trunk/subversion/libsvn_subr/spillbuf.c Thu Aug 31 16:01:57 2017
@@ -265,10 +265,10 @@ svn_spillbuf__write(svn_spillbuf_t *buf,
 
           /* Adjust the start offset for reading from the spill file.
 
-             ### FIXME: Instead, we should simply discard the memory
-             buffers; but currently some tests expect to read data in
-             the same chunk sizes as were written, so we'll leave this
-             change for later.*/
+             This way, the first `buf->memory_size` bytes of data will
+             be read from the existing in-memory buffers, which makes
+             more sense than discarding the buffers and re-reading
+             data from the file. */
           buf->spill_start = buf->memory_size;
         }
     }



Mime
View raw message