Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 47F17200CD6 for ; Mon, 31 Jul 2017 17:46:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 46777163B1A; Mon, 31 Jul 2017 15:46:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DA7A163B0E for ; Mon, 31 Jul 2017 17:46:02 +0200 (CEST) Received: (qmail 20891 invoked by uid 500); 31 Jul 2017 15:45:59 -0000 Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@subversion.apache.org Delivered-To: mailing list commits@subversion.apache.org Received: (qmail 20861 invoked by uid 99); 31 Jul 2017 15:45:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Jul 2017 15:45:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 071D0180418 for ; Mon, 31 Jul 2017 15:45:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=visualsvn.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1Itots47Xk9v for ; Mon, 31 Jul 2017 15:45:56 +0000 (UTC) Received: from mail-qt0-f171.google.com (mail-qt0-f171.google.com [209.85.216.171]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8EDED5F523 for ; Mon, 31 Jul 2017 15:45:55 +0000 (UTC) Received: by mail-qt0-f171.google.com with SMTP id a18so92143925qta.0 for ; Mon, 31 Jul 2017 08:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=visualsvn.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9kfiwZggW0dbOnbCX4djSQbU79kUNaWEOOfdP2i4Wwo=; b=TNQ9ej4yYrL4gRwXJpv7ieTZt36Pn1EaTsoLjZhbANIfYWQIEorzxzHHHM8/SifVQD l+AUp2V56+/tvNRnfPR5a6Vjan2Kzu2+09xrHRM9Q0sb440EzJ6QrFcL1SOHNkhBJr17 EruDhqFxJqmOgieSy1W87tuhEJE3Cv6ezkLCk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9kfiwZggW0dbOnbCX4djSQbU79kUNaWEOOfdP2i4Wwo=; b=exPeD082UrtDcp9GnAAfZRIG7OYNGAwvqenoFPMUYTi5JY/xULaPz3t5s1Uguacrba UwX/7yMfyDS1JWo2M7VmjAGz7TUkSbCdOnJj+WrAU7xPD11KbCDQ7wmpldsREbSiFTei jJeYjMLRgp5yuTAmxnR8NRysLE5k6rIUvSx1PX9OILpf87m2zmQdruc9ZvOatCeqiTNM slB3d3k3s0gKwKY+HdV9C3Lq8595HpPOdpabhdLX5qGn3H1jCt/cnRDoi+KnkAZgBtpL Sf9kn9rZEamMtUMuQfem5mofFwjZcDaSunBGpn6Uui8l32e4npN6Gjj9u1WNcxyO1ZiT axLQ== X-Gm-Message-State: AIVw113OYoDi2/sk/7WaG+w7e5VbbSv2D3gYmpQ0/6C432JYVQqLUlES x4AcBaDKLiF3gSVSJRk06CT0GO4O8EuT X-Received: by 10.237.63.45 with SMTP id p42mr21063056qtf.320.1501515954454; Mon, 31 Jul 2017 08:45:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.139.100 with HTTP; Mon, 31 Jul 2017 08:45:34 -0700 (PDT) In-Reply-To: <20170731152114.6xegfhcfxonfuwhl@tarpaulin.shahaf.local2> References: <20170727085354.4EF7C3A04C0@svn01-us-west.apache.org> <1501156786.3174680.1054323864.2DFC72CC@webmail.messagingengine.com> <1501242259.2452442.1055492024.6A26E5A2@webmail.messagingengine.com> <20170731152114.6xegfhcfxonfuwhl@tarpaulin.shahaf.local2> From: Evgeny Kotkov Date: Mon, 31 Jul 2017 18:45:34 +0300 Message-ID: Subject: Re: svn commit: r1803140 - in /subversion/trunk/subversion: include/svn_delta.h libsvn_delta/svndiff.c tests/libsvn_delta/random-test.c To: Daniel Shahaf Cc: Subversion Development , commits@subversion.apache.org Content-Type: text/plain; charset="UTF-8" archived-at: Mon, 31 Jul 2017 15:46:03 -0000 Daniel Shahaf writes: >> Perhaps, I could add a couple of comments on this. > > That would be great. It'll ensure we don't forget about this dependency > when we revv one of these functions. Thank you for following up on this. I added several comments in https://svn.apache.org/r1803546 Regards, Evgeny Kotkov