subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svn commit: r1785734 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
Date Mon, 06 Mar 2017 20:53:13 GMT
stefan2@apache.org wrote on Mon, Mar 06, 2017 at 19:05:45 -0000:
> +static svn_error_t *
> +test_rep_sharing_strict_content_check(const svn_test_opts_t *opts,
> +                                      apr_pool_t *pool)
> +{
> +  /* Bail (with success) on known-untestable scenarios */
> +  if (strcmp(opts->fs_type, SVN_FS_TYPE_BDB) == 0)
> +    return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
> +                            "this will not test BDB repositories");

Minor point: the log message^W^W skip message should answer "Why", not
"What".  Suggestion:

    "bdb does not have a rep-cache"

Mime
View raw message