subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From james...@apache.org
Subject svn commit: r1766323 - /subversion/trunk/subversion/libsvn_subr/gpg_agent.c
Date Mon, 24 Oct 2016 01:58:21 GMT
Author: jamessan
Date: Mon Oct 24 01:58:21 2016
New Revision: 1766323

URL: http://svn.apache.org/viewvc?rev=1766323&view=rev
Log:
* subversion/libsvn_subr/gpg_agent.c
  (simple_gpg_agent_next_creds): Unconditionally call bye_gpg_agent when we're
   done with gpg-agent to fix a file descriptor leak.

Modified:
    subversion/trunk/subversion/libsvn_subr/gpg_agent.c

Modified: subversion/trunk/subversion/libsvn_subr/gpg_agent.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/gpg_agent.c?rev=1766323&r1=1766322&r2=1766323&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/gpg_agent.c (original)
+++ subversion/trunk/subversion/libsvn_subr/gpg_agent.c Mon Oct 24 01:58:21 2016
@@ -610,11 +610,10 @@ simple_gpg_agent_next_creds(void **crede
       return SVN_NO_ERROR;
     }
 
+  bye_gpg_agent(sd);
+
   if (strncmp(buffer, "OK\n", 3) != 0)
-    {
-      bye_gpg_agent(sd);
-      return SVN_NO_ERROR;
-    }
+    return SVN_NO_ERROR;
 
   /* TODO: This attempt limit hard codes it at 3 attempts (or 2 retries)
    * which matches svn command line client's retry_limit as set in



Mime
View raw message