Mailing-List: contact commits-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@subversion.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1758202 - /subversion/trunk/subversion/mod_dav_svn/repos.c
Date: Mon, 29 Aug 2016 10:35:20 -0000
To: commits@subversion.apache.org
From: kotkov@apache.org
Message-Id: <20160829103520.0ABF83A028F@svn01-us-west.apache.org>
archived-at: Mon, 29 Aug 2016 10:35:28 -0000

Author: kotkov
Date: Mon Aug 29 10:35:19 2016
New Revision: 1758202

URL: http://svn.apache.org/viewvc?rev=1758202&view=rev
Log:
* subversion/mod_dav_svn/repos.c
  (close_filter): Cleanup the brigade after the ap_pass_brigade() call.
   Although it's not strictly required in this stream's close_fn, because
   we always call apr_brigade_destroy() upon returning from the deliver()
   hook, generally, this is the right thing to do.

Modified:
    subversion/trunk/subversion/mod_dav_svn/repos.c

Modified: subversion/trunk/subversion/mod_dav_svn/repos.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/repos.c?rev=1758202&r1=1758201&r2=1758202&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/repos.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/repos.c Mon Aug 29 10:35:19 2016
@@ -3268,7 +3268,10 @@ close_filter(void *baton)
   /* done with the file. write an EOS bucket now. */
   bkt = apr_bucket_eos_create(dc->output->c->bucket_alloc);
   APR_BRIGADE_INSERT_TAIL(dc->bb, bkt);
-  if ((status = ap_pass_brigade(dc->output, dc->bb)) != APR_SUCCESS)
+  status = ap_pass_brigade(dc->output, dc->bb);
+  apr_brigade_cleanup(dc->bb);
+
+  if (status != APR_SUCCESS)
     return svn_error_create(status, NULL, "Could not write EOS to filter");
 
   return SVN_NO_ERROR;