subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@apache.org>
Subject Re: svn commit: r1748030 - /subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c
Date Sun, 12 Jun 2016 18:16:16 GMT
On 12.06.2016 19:45, stefan2@apache.org wrote:
> Author: stefan2
> Date: Sun Jun 12 17:45:49 2016
> New Revision: 1748030
>
> URL: http://svn.apache.org/viewvc?rev=1748030&view=rev
> Log:
> On the authzperf branch:
> Make the authz parser accept "/" in repository names.  The repository name
> may contain a relative path if the repo is located deeper down the file tree.
> The repository name still lives within a flat namespace - now simply allowing
> for '/' - and creates a separate namespace for in-repo paths.
>
> This fixes the svnsync tests.
>
> * subversion/libsvn_repos/authz_parse.c
>   (rules_open_section): Remove the check for '/' in repository names.
>
> Modified:
>     subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c
>
> Modified: subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c
> URL: http://svn.apache.org/viewvc/subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c?rev=1748030&r1=1748029&r2=1748030&view=diff
> ==============================================================================
> --- subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c (original)
> +++ subversion/branches/authzperf/subversion/libsvn_repos/authz_parse.c Sun Jun 12 17:45:49
2016
> @@ -730,13 +730,6 @@ rules_open_section(void *baton, svn_stri
>              _("Empty repository name in authz rule [%s]"),
>              section->data);
>  
> -      if (memchr(rule, '/', repos_len))
> -        return svn_error_createf(
> -            SVN_ERR_AUTHZ_INVALID_CONFIG, NULL,
> -            _("Invalid repository name '%s' in authz rule [%s]"),
> -            apr_pstrmemdup(cb->parser_pool, rule, repos_len),
> -            section->data);
> -
>        acl.acl.rule.repos = intern_string(cb, rule, repos_len);
>        rule = endp + 1;
>        rule_len -= repos_len + 1;

Do we actually have reports of real-world cases where the limitation you
just removed was relevant? I can imagine this could only happen for
repositories that are served by svnserve, not mod_dav_svn, right?

-- Brane

Mime
View raw message