subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stef...@apache.org
Subject svn commit: r1744979 - /subversion/trunk/build/run_tests.py
Date Sat, 21 May 2016 20:24:47 GMT
Author: stefan2
Date: Sat May 21 20:24:47 2016
New Revision: 1744979

URL: http://svn.apache.org/viewvc?rev=1744979&view=rev
Log:
Finish the log writer work: Cleanup.

* build/run_tests.py
  (TestHarness.run):  Remove obsolete comment.  The codecs output seems to 
                      work just fine with any binary data in the log.
  (TestHarness._open_log):  We never open the log in binary mode anymore.

Modified:
    subversion/trunk/build/run_tests.py

Modified: subversion/trunk/build/run_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=1744979&r1=1744978&r2=1744979&view=diff
==============================================================================
--- subversion/trunk/build/run_tests.py (original)
+++ subversion/trunk/build/run_tests.py Sat May 21 20:24:47 2016
@@ -575,10 +575,7 @@ class TestHarness:
     else:
       failed = self._run_global_sheduler(testlist, len(py_tests) > 0)
 
-    # Open the log in binary mode because it can contain binary data
-    # from diff_tests.py's testing of svnpatch. This may prevent
-    # readlines() from reading the whole log because it thinks it
-    # has encountered the EOF marker.
+    # Open the log again to for filtering.
     if self.logfile:
       self._open_log('r')
       log_lines = self.log.readlines()
@@ -718,10 +715,7 @@ class TestHarness:
     'Open the log file with the required MODE.'
     if self.logfile:
       self._close_log()
-      if 'b' in mode:
-        self.log = open(self.logfile, mode)
-      else:
-        self.log = codecs.open(self.logfile, mode, encoding="latin-1")
+      self.log = codecs.open(self.logfile, mode, encoding="latin-1")
 
   def _close_log(self):
     'Close the log file.'



Mime
View raw message