subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stef...@apache.org
Subject svn commit: r1743057 - /subversion/trunk/build/run_tests.py
Date Mon, 09 May 2016 21:18:13 GMT
Author: stefan2
Date: Mon May  9 21:18:13 2016
New Revision: 1743057

URL: http://svn.apache.org/viewvc?rev=1743057&view=rev
Log:
Follow-up to r1743052:  Make the fails.log generation actually work with py3.

* build/run_tests.py
  (TestHarness.run):  The filtered lists contain strings while the plain log
                      lines are binary.  Convert before comparing them.

Modified:
    subversion/trunk/build/run_tests.py

Modified: subversion/trunk/build/run_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=1743057&r1=1743056&r2=1743057&view=diff
==============================================================================
--- subversion/trunk/build/run_tests.py (original)
+++ subversion/trunk/build/run_tests.py Mon May  9 21:18:13 2016
@@ -693,7 +693,8 @@ class TestHarness:
         # Iterate the lines.  If it ends a test we're interested in, dump that
         # test to FAILLOG.  If it starts a test (at all), remember the line
         # number (in case we need it later).
-        if line in xpassed or line in failed_list:
+        line_str = ensure_str(line)
+        if line_str in xpassed or line_str in failed_list:
           faillog.write(b'[[[\n')
           faillog.writelines(log_lines[last_start_lineno : lineno+1])
           faillog.write(b']]]\n\n')



Mime
View raw message