subversion-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kot...@apache.org
Subject svn commit: r1741200 - /subversion/trunk/subversion/libsvn_fs_fs/transaction.c
Date Wed, 27 Apr 2016 10:25:13 GMT
Author: kotkov
Date: Wed Apr 27 10:25:13 2016
New Revision: 1741200

URL: http://svn.apache.org/viewvc?rev=1741200&view=rev
Log:
Following up on r1741096, simplify the error handling code.

* subversion/libsvn_fs_fs/transaction.c
  (svn_fs_fs_commit): Remove a superfluous check for `err', since
   svn_error_find_cause() can accept an SVN_NO_ERROR.

Modified:
    subversion/trunk/subversion/libsvn_fs_fs/transaction.c

Modified: subversion/trunk/subversion/libsvn_fs_fs/transaction.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/transaction.c?rev=1741200&r1=1741199&r2=1741200&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/transaction.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/transaction.c Wed Apr 27 10:25:13 2016
@@ -3840,7 +3840,7 @@ svn_fs_fs__commit(svn_revnum_t *new_rev_
       err = write_reps_to_cache(fs, cb.reps_to_cache, pool);
       err = svn_sqlite__finish_transaction(ffd->rep_cache_db, err);
 
-      if (err && svn_error_find_cause(err, SVN_ERR_SQLITE_ROLLBACK_FAILED))
+      if (svn_error_find_cause(err, SVN_ERR_SQLITE_ROLLBACK_FAILED))
         {
           /* Failed rollback means that our db connection is unusable, and
              the only thing we can do is close it.  The connection will be



Mime
View raw message